[Bug 237883] Review Request: perl-SGML-Parser-OpenSP - Perl interface to the OpenSP SGML and XML parser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SGML-Parser-OpenSP - Perl interface to the OpenSP SGML and XML parser


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237883


ville.skytta at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?




------- Additional Comments From ville.skytta at iki.fi  2007-05-06 14:02 EST -------
(In reply to comment #9)
> You should include perl(Test::More) as an explicit BR -- I'm not seeing it 
> being pulled in by perl-Test-Pod (on my system at least).

It should; see comment 6 for description of the dep chain.  But I don't see it
causing any harm and it's directly required, so will add.

> Taking care of the rpmlint
> warnings is trivial in %prep -- sed -i 's/\r//' samples/* -- so this should be
> taken care of as well.

The samples are not included, see comment 6 for the rationale.  If you can think
of where they could be useful when installed, let me know.

Thanks for the review!

New Package CVS Request
=======================
Package Name: perl-SGML-Parser-OpenSP
Short Description: Perl interface to the OpenSP SGML and XML parser
Owners: ville.skytta at iki.fi
Branches: 
InitialCC: fedora-perl-devel-list at redhat.com

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.