[Bug 239156] Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects
bugzilla at redhat.com
bugzilla at redhat.com
Sun May 6 18:25:52 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects
Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
------- Additional Comments From cweyl at alumni.drew.edu 2007-05-06 14:25 EST -------
Missing BR's on:
perl(ExtUtils::MakeMaker)
perl(Test::More)
perl(Test::Pod)
perl(Test::Pod::Coverage)
rpmlint complains about tabs/spaces -- this should be an easy fix.
Also, for a variety of reasons, this package should own the entire directory
chain under %{perl_vendorlib}, e.g., not %{perl_vendorlib}/DBIx/SQLite/* but
just %{perl_vendorlib}/*.
Correct the BR's, pacify rpmlint and correct %files and I'll approve :)
+ source files match upstream:
7375627800f0ef136eff5ef18c766c64 DBIx-SQLite-Simple-0.34.tar.gz
7375627800f0ef136eff5ef18c766c64 DBIx-SQLite-Simple-0.34.tar.gz.srpm
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text included in package.
+ latest version is being packaged.
X BuildRequires are proper.
+ compiler flags are appropriate. (noarch)
+ %clean is present.
X rpmlint is silent (see below)
+ final provides and requires are sane:
** perl-DBIx-SQLite-Simple-0.34-1.fc6.src.rpm
W: perl-DBIx-SQLite-Simple mixed-use-of-spaces-and-tabs (spaces: line 1, tab:
line 9)
** perl-DBIx-SQLite-Simple-0.34-1.fc6.noarch.rpm
== rpmlint
== provides
perl(DBIx::SQLite::Simple) = 0.34
perl(DBIx::SQLite::Simple::Table)
perl-DBIx-SQLite-Simple = 0.34-1.fc6
== requires
perl(:MODULE_COMPAT_5.8.8)
perl(Carp)
perl(Class::Gomor::Array)
perl(DBI)
perl(DBIx::SQLite::Simple)
perl(strict)
perl(warnings)
+ %check is present and all tests pass:
All tests successful.
Files=6, Tests=8, 1 wallclock secs ( 0.50 cusr + 0.14 csys = 0.64 CPU)
+ no shared libraries are added to the regular linker search paths.
X owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list