[Bug 239091] Review Request: halberd - Tool to discover HTTP load balancers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: halberd - Tool to discover HTTP load balancers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239091


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-05-07 02:00 EST -------
Not much to say here; a clean package which builds and runs fine.  rpmlint has
nothing to say.  The only thing I can really say is that you're supposed to
choose one of the defines at the top of the spec (in this case, the "sitelib"
one) and then delete the other line and the comment.  This isn't a big deal.

It would be nice if upstream would consider including the license text.  Right
now the installed package contains nothing which actually indicates the licence;
only the PKG-INFO and setyp.py files in the tarball have it.  Perhaps you could
ping them about it.

* source files match upstream:
   7c31ccd75cb9932150f699975f11f7750c13f8b6593db9c41b293d4408ce8474  
   halberd-0.2.1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   halberd = 0.2.1-1.fc7
  =
   /usr/bin/python
   python(abi) = 2.5
* %check is not present; not possible to run tests without network access.
  Manual testing reveals no issues.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la droppings.
* not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.