[Bug 239157] Review Request: perl-Net-Pcap - Interface to pcap LBL packet capture library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Pcap - Interface to pcap LBL packet capture library
Alias: perl-Net-Pcap

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239157





------- Additional Comments From cweyl at alumni.drew.edu  2007-05-08 02:11 EST -------
License tag is generally written as "GPL or Artistic", by convention.

Missing br's on:
    perl(ExtUtils::MakeMaker)
    perl(Test::More)

As many of the tests skip themselves ("must be run as root"), I'd recommend
adding t/ to %doc.  (If you do this, rpmlint will generate an ignorable
"perl-Net-Pcap doc-file-dependency perl(Socket)" warning.)

All tests pass, but:

t/10-fileno.........ok                                                       
        1/21 unexpectedly succeeded

Why is this test not failing, as it should?  Is this a real problem or did
upstream just forget to remove the "TODO" designation to this test?

This package needs to own %{perl_vendorarch}/Net.  %{perl_vendorarch}/Net/* in
%files should just be %{perl_vendorarch}/Net.

So, at the very least, we need to add the br's, figure out why that test isn't
failing, change license to "GPL or Artistic", and correct %files.

+ source files match upstream:
80a4b62911cded1a011b897f735d445e  Net-Pcap-0.14.tar.gz
80a4b62911cded1a011b897f735d445e  ../Net-Pcap-0.14.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
O license field matches the actual license.
+ license is open source-compatible.  License text not included upstream.
+ latest GA version is being packaged.
X BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
+ debuginfo package looks complete.
+ rpmlint is silent.
+ final provides and requires are sane:
 ** perl-Net-Pcap-0.14-1.fc6.x86_64.rpm
 == rpmlint
 == provides
 Pcap.so()(64bit)  
 perl(Net::Pcap) = 0.14
 perl-Net-Pcap = 0.14-1.fc6
 == requires
 /usr/bin/perl  
 libc.so.6()(64bit)  
 libc.so.6(GLIBC_2.2.5)(64bit)  
 libpcap.so.0.9.4()(64bit)  
 perl(:MODULE_COMPAT_5.8.8)  
 perl(AutoLoader)  
 perl(Carp)  
 perl(Exporter)  
 perl(IO::Interface)  
 perl(IO::Socket)  
 perl(Net::Pcap)  
 perl(Sys::Hostname)  
 perl(strict)  
 rtld(GNU_HASH)  
 ** perl-Net-Pcap-debuginfo-0.14-1.fc6.x86_64.rpm
 == rpmlint
 == provides
 Pcap.so.debug()(64bit)  
 perl-Net-Pcap-debuginfo = 0.14-1.fc6
 == requires
+ %check is present and all tests pass:
 All tests successful, 11 tests and 83 subtests skipped.
 Files=24, Tests=500,  3 wallclock secs ( 1.44 cusr +  0.57 csys =  2.01 CPU)
+ no shared libraries are added to the regular linker search paths.
X owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.