[Bug 233782] Review Request: vegastrike - 3D OpenGL spaceflight simulator

bugzilla at redhat.com bugzilla at redhat.com
Wed May 9 14:52:30 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vegastrike - 3D OpenGL spaceflight simulator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233782





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-05-09 10:52 EST -------
(In reply to comment #14)
> Looks like the line including the patch needs to be commented out.
> 
It has this comment above it:
# not applied as no longer needed, kept for reference

Commenting it out will exclude it from the srpm and from cvs-import, which is
not what I want.

> License is good, but COPYING needs to be included in %doc, along with AUTHORS,
> DOCUMENTATION, etc.
> 

Good catch will fix.

(In reply to comment #16)
> Mock builds fine.  BRs are OK.  All other MUSTS are met.
> 
> Looks like it's just the %doc issue and the patch question.

See above, here is a new version with the %doc fixed:
http://people.atrpms.net/~hdegoede/vegastrike.spec
http://people.atrpms.net/~hdegoede/vegastrike-0.4.3-3.fc7.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list