[Bug 225575] Review Request: roundcubemail - Round Cube Webmail is a browser-based multilingual IMAP client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: roundcubemail - Round Cube Webmail is a browser-based multilingual IMAP client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225575





------- Additional Comments From limb at jcomserv.net  2007-05-09 14:05 EST -------
(In reply to comment #39)
> (In reply to comment #38)
> > %attr(0644,root,apache) %config(noreplace) %{_sysconfdir}/*
> 
> %attr(0644,root,apache) %config(noreplace) %{_sysconfdir}/%{name}/*

Thanks, I intuited that. :)

(In reply to comment #40)
> (In reply to comment #38)
> > > W: roundcubemail spurious-executable-perm
> > 
> > Change the mode on these files to 0644 with chmod or install -m in the %install
> > section.
> 
> Sorry for the followups, I missed a few things without looking at the spec.  I
> don't think you need any executables in the source files, so you should be
able to:
> 
> In %prep (after %setup), run
> 
> find . -type f -print | xarg chmod a-x
> 
> Then all those %attr lines with %roundcubemail can be replaced by just:
> %{roundcubedir}
> because there won't be permissions to fix (that's causing duplicate file
> listings in the rpm anyway).
> 
> These odd permissions should be reported upstream as "undesirable".
> 

That's great, but what's xarg?
[limb at fawkes SPECS]$ rpmbuild -ba roundcubemail.spec
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.91340
+ umask 022
+ cd /usr/src/redhat/BUILD
+ LANG=C
+ export LANG
+ unset DISPLAY
+ cd /usr/src/redhat/BUILD
+ rm -rf roundcubemail-0.1beta2
+ /bin/gzip -dc /usr/src/redhat/SOURCES/roundcubemail-0.1beta2.2.tar.gz
+ tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd roundcubemail-0.1beta2
++ /usr/bin/id -u
+ '[' 500 = 0 ']'
++ /usr/bin/id -u
+ '[' 500 = 0 ']'
+ /bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ find . -type f -print
+ xarg chmod a-x
/var/tmp/rpm-tmp.91340: line 37: xarg: command not found
error: Bad exit status from /var/tmp/rpm-tmp.91340 (%prep)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.91340 (%prep)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.