[Bug 233424] Review Request: perl-mecab - Perl binding for MeCab

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-mecab - Perl binding for MeCab


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233424


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |pertusus at free.fr
               Flag|                            |fedora-review+




------- Additional Comments From pertusus at free.fr  2007-05-09 16:41 EST -------
* rpmlint is silent
* name is right
* follows guidelines
* free software licences, included. Files are generated using SWIG, so
  there may be an issue with GPL/LGPL since the swig template is
  missing and proper license headers are missing, and no word about license
  in the README. However mecab is also packaged and people can go to
  the website so it is likely to be right as said in other reviews.
* match upstream
b924751bf58d7d6c4f3b6b5bbe8e1640  mecab-perl-0.95.tar.gz
* sane provides
Provides: MeCab.so perl(MeCab) perl(MeCab::DictionaryInfo) perl(MeCab::Node)
perl(MeCab::Path) perl(MeCab::Tagger) perl(MeCabc)
* %files section right

APPROVED

About -f, for directories, indeed you need the -f, but my 
comments were for
	%{__mv} -f test.pl.utf8 test.pl || \
	%{__rm} -f test.pl.utf8

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.