[Bug 172869] Review Request: nss-mdns

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nss-mdns


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172869


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs at math.uh.edu




------- Additional Comments From tibbs at math.uh.edu  2007-05-09 19:18 EST -------
I'd like to look into this because I think it may be useful for a network
configuration I'm investigating, but I'm concerned about the above reports and I
also note that there's a 0.9 version out there currently.

The package does build, but the install is a bit confused:

/var/tmp/rpm-tmp.80770: line 3: fg: no job control
error: %post(nss-mdns-0.8-2.x86_64) scriptlet failed, exit status 1

A few other comments:

rpmlint wants the summary capitalized, but I wouldn't capitalize it in this
situation either.

You need Requires(pre): /sbin/ldconfig
You could just use %postun -p /sbin/ldconfig or add
  Requires(postun): /sbin/ldconfig

You really shouldn't use %makeinstall unless
  make DESTDIR=$RPM_BUILD_ROOT install
doesn't work.

I can't say that I'm confortable with automatically adding the library to
nsswitch.conf, but I suppose the point is that it needs no configurarion.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.