[Bug 239525] Review Request: gammu - Command Line utility and Libraries to work with mobile phones

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gammu - Command Line utility and Libraries to work with mobile phones


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239525





------- Additional Comments From panemade at gmail.com  2007-05-10 06:29 EST -------
Ok so new SRPM gave me following rpmlint warnings which can be ignored as I saw
some core packages are also allowing following rpmlint warnings

W: gammu spurious-executable-perm /usr/share/doc/gammu-1.10.0/examples/ppp/startppp
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

W: gammu spurious-executable-perm /usr/share/doc/gammu-1.10.0/examples/fax/faxsend
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

W: gammu spurious-executable-perm
/usr/share/doc/gammu-1.10.0/examples/fax/faxreceive
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

W: gammu spurious-executable-perm /usr/share/doc/gammu-1.10.0/examples/ppp/gprs
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

W: gammu spurious-executable-perm /usr/share/doc/gammu-1.10.0/examples/ppp/statsppp
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

W: gammu spurious-executable-perm /usr/share/doc/gammu-1.10.0/examples/ppp/data
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

W: gammu doc-file-dependency /usr/share/doc/gammu-1.10.0/examples/fax/faxreceive
/bin/sh
An included file marked as %doc creates a possible additional dependency in
the package.  Usually, this is not wanted and may be caused by eg. example
scripts with executable bits set included in the package's documentation.

W: gammu doc-file-dependency /usr/share/doc/gammu-1.10.0/examples/fax/faxsend
/bin/sh
An included file marked as %doc creates a possible additional dependency in
the package.  Usually, this is not wanted and may be caused by eg. example
scripts with executable bits set included in the package's documentation.

W: gammu doc-file-dependency /usr/share/doc/gammu-1.10.0/examples/ppp/data /bin/sh
An included file marked as %doc creates a possible additional dependency in
the package.  Usually, this is not wanted and may be caused by eg. example
scripts with executable bits set included in the package's documentation.

W: gammu doc-file-dependency /usr/share/doc/gammu-1.10.0/examples/ppp/gprs /bin/sh
An included file marked as %doc creates a possible additional dependency in
the package.  Usually, this is not wanted and may be caused by eg. example
scripts with executable bits set included in the package's documentation.

W: gammu doc-file-dependency /usr/share/doc/gammu-1.10.0/examples/ppp/startppp
/bin/sh
An included file marked as %doc creates a possible additional dependency in
the package.  Usually, this is not wanted and may be caused by eg. example
scripts with executable bits set included in the package's documentation.

W: gammu doc-file-dependency /usr/share/doc/gammu-1.10.0/examples/ppp/statsppp
/bin/sh
An included file marked as %doc creates a possible additional dependency in
the package.  Usually, this is not wanted and may be caused by eg. example
scripts with executable bits set included in the package's documentation.

But I think you should solve follwoing easily
W: gammu mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

Ok so no problem for -libs subpackage.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.