[Bug 238367] Review Request: xu4 - Ultima IV recreated

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xu4 - Ultima IV recreated
Alias: xu4

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238367


chris.stone at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From chris.stone at gmail.com  2007-05-11 16:29 EST -------
==== REVIEW GUIDELINES ====
- rpmlint output clean
- package named according to package naming guidelines
- package meets packaging guidelines
- package licensed with open source compatible license
- license matches actual license
- license file included in %doc
- spec written in American english
- spec file legible
- sources match upstream
# diff -ubBr /home/fedora/rpmbuild/SPECS/u4/ /home/chris/cvs/u4/
- package successfully compiles on x86_64 FC6
- all build dependencies in BR
- no locales
- no shared libraries
- package is not relocatable
- package owns all directories it creates
- directories it does not create are brought in through Requires
- no duplicates in %files
- file permissions set properly
- contains proper %clean
- macro usage consistent
- contains code
- no large documentation
- files in %doc do not affect runtime
- no header files
- no static libraries
- no pkgconfig files
- no library with suffix
- no need for devel subpackage
- no libtool archives
- contains proper .desktop file
- does not own files or directories owned by other packages
- contains proper install
- all filenames utf-8

==== SHOULD FIX ====
- spec comments should show how to check out code from the cvs on or before the
date of cvsdate.  I think cvs ... -D %{cvsdate} might work.

**** APPROVED ****


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.