[Bug 238348] Review Request: xfce4-verve-plugin - A comfortable command line plugin for the Xfce panel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-verve-plugin - A comfortable command line plugin for the Xfce panel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238348


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From kevin at tummy.com  2007-05-12 19:36 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
85701b960da6bb10762b460c23b84c15  verve-plugin-0.3.5.tar.bz2
85701b960da6bb10762b460c23b84c15  verve-plugin-0.3.5.tar.bz2.1
OK - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. Should the "Requires:       xfce4-panel >= 4.4.0" be 4.4.1, since
we know that in fc6/devel/f7 at least it will be built against 4.4.1,
so perhaps it should require at least that version? No big deal, since
4.4.0 and 4.4.1 should be pretty much the same for xfce4-panel-devel, but
just thought I would mention it. Not a blocker.

As hard as I may try I can't see anything blocking this package. ;)

This package is APPROVED.
Don't forget to close this review request once it's been imported and built


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.