[Bug 239812] Review Request: nagi - An interpreter for AGI games

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagi - An interpreter for AGI games


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239812





------- Additional Comments From tibbs at math.uh.edu  2007-05-15 15:19 EST -------
I was typing this up but someone else submitted comments first.  Here's what I
had written:

This is assigned but the fedora-review tag is unset.  Is someone reviewing this?

The build fails for me on x86_64:

+ make -f Makefile.linux
gcc -O2  -Wall -Winline -Wshadow -Wstrict-prototypes -DRAD_LINUX -DRAD_WARN -c
base.c -o base.o
In file included from base.c:7:
agi.h:5:21: error: SDL/SDL.h: No such file or directory

(and cascading failures)  Looks like a build depndency on SDL-devel is missing. 
Adding that gets things building.

The Version and Release are a bit off.  First, isn't this version 2.06?  The
upstream web seem to call it that.  If so, release should probably be just "1".
 If you're using some sort of prerelease snapshot then you'd have a release of
"0.1.2002114%{?dist}", but I'm not sure what's up there.

The tarball unpacks into multiple directories, but you have setup cd into one of
them (src) and then escape from that directory to get to the others.  That's
kind of bad form and will leave things laying around in the buildroot after the
package has built.  I suggest using something like
  %setup -qc ${name}-%{version}
to keep everything tidy.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.