[Bug 240635] Review Request: mash - tree creation tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mash - tree creation tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240635





------- Additional Comments From notting at redhat.com  2007-05-22 02:12 EST -------
(In reply to comment #1)
> Issues:
> 
> 1. Cosmetic/nonblocker:
> Summary:        Buildsystem -> tree converter
> seems a bit terse... perhaps:
> Summary:        Koji buildsystem to yum repository converter
> ?

OK, will fix.

 
> 2. ChangeLog and README are 0 length. Should they be shipped?

<packager hat> *shrug*, that's an upstream issue.

> Should they have content?

<upstream hat> Yeah, they should. I need to get a format out of git log that I
can stand to read.

> 3. The Source0 URL doesn't seem to work. Seems to have lots of older versions, but
> not this one. Perhaps it should point to the hosted site?

Should be fixed. Also, see next answer...

> 4. The URL seems to give:
> Environment not found

Yeah, I need to get Jesse to set up the trac bits.

> 5. rpmlint says:
> E: mash non-executable-script
/usr/lib/python2.5/site-packages/mash/multilib.py 0644
> E: mash non-executable-script /usr/lib/python2.5/site-packages/mash/config.py 0644
> E: mash non-executable-script
/usr/lib/python2.5/site-packages/mash/__init__.py 0644
> 
> Should these have no #! line? or should they be 755?

Probably one or the other. I'll look at taking the #! out of them. Doesn't
affect anything.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.