[Bug 235293] Review Request: adminutil - Utility library for Fedora Directory Server administration

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: adminutil - Utility library for Fedora Directory Server administration
Alias: adminutil

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235293





------- Additional Comments From rmeggins at redhat.com  2007-05-23 16:53 EST -------
(In reply to comment #20)
> Still not enough
> * undefined non-weak symbols
>   - libadmsslutil.so.1.1.1 contains undefined non-weak
>     symbols. This is not allowed for packages to provide
>     -devel subpackages because linkage against this
>     library fails due to these symbols.

Fixed - added linkage against libadminutil.la

> * Timestamps
>   - -devel package contains many header files (i.e. text
>     files which are not created or modified during rebuild)
>     and keeping timestamps on these files are recommend.
>     Please use:
> ---------------------------------------------------
> make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p"
> ---------------------------------------------------

Done.

> * macros consistency
>   - Please determine to use macros or not to use macros
>     for binaries. Please don't use both "rm" and "%{__rm}"
>     If you want to use %{__rm}, please also use %{__make},
>     for example.

Done.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.