[Bug 241099] Review Request: lcdtest - utility to display monitor test patterns

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lcdtest - utility to display monitor test patterns


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241099





------- Additional Comments From wolfy at nobugconsulting.ro  2007-05-24 04:48 EST -------
Hi Eric
there are a few problems with the spec, but luckily they are easy to fix
- BuildRoot should have one of the values listed at
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473
- The spec must include a %clean section. Please add
  %clean
  rm -rf $RPM_BUILD_ROOT
after the %install section
- Using %defattr(-,root,root,-) is saner


Please also note that SDL-devel is already pulled in by SDL_image-devel, so
there is no need to BR it.

And now the sad part: mock build (building for F7/x86_64) fails with the
following error:

+ scons destdir=/var/tmp/lcdtest-1.06-build bindir=/usr/bin
mandir=/usr/share/man/man1
scons: Reading SConscript files ...
<type 'exceptions.AttributeError'>: SConsEnvironment instance has no attribute
'MergeFlags':
  File "SConstruct", line 139:
    exports = {'env' : env})
  File "/usr/lib/scons/SCons/Script/SConscript.py", line 581:
    return apply(method, args, kw)
  File "/usr/lib/scons/SCons/Script/SConscript.py", line 508:
    return apply(_SConscript, [self.fs,] + files, {'exports' : exports})
  File "/usr/lib/scons/SCons/Script/SConscript.py", line 239:
    exec _file_ in stack[-1].globals
  File "src/SConscript", line 67:
    env.MergeFlags (os.environ ['CFLAGS'])
error: Bad exit status from /var/tmp/rpm-tmp.75447 (%build)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.75447 (%build)



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.