[Bug 241099] Review Request: lcdtest - utility to display monitor test patterns

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lcdtest - utility to display monitor test patterns


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241099





------- Additional Comments From wolfy at nobugconsulting.ro  2007-05-25 21:49 EST -------
Excellent, things are almost fine. Some cosmetic fixes are needed to make
rpmlint happy:
Source RPM:
W: lcdtest summary-not-capitalized displays monitor test patterns
->Obvious fix
W: lcdtest rpm-buildroot-usage %build destdir=$RPM_BUILD_ROOT \
->Ignorable, scons needs this
W: lcdtest macro-in-%changelog _smp_mflags
->use %% instead of %
W: lcdtest mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 11)
->please stick with either spaces or tabs, if possible

rpmlint of lcdtest:
W: lcdtest summary-not-capitalized displays monitor test patterns
-> will be fixed in the same time with the src.rpm

Except for the above (and the fact that scons-0.9.7 has not yet been pushed in
devel) everything seems fine, including using the program on FC6/x86_64.


Have you not have been in the position of needing a sponsor I would have
approved the package.

here comes a formal review, to help potential sponsors:
GOOD
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream, is latest version, SHA1SUM is
9da6385dad834ae8073bb0ef7620e32122cec4d9
- package compiles on FC6 (x86_64) [*]
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
NEEDSWORK
- cosmetic changes of spec, see on top of this comment


[*] as of 25.05.2007, needed BR scons>=0.9.7 is not yet available in devel,
probably due to F7 freeze


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.