[Bug 240639] Review Request: perl-URI-Fetch - Smart URI fetching/caching

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-URI-Fetch - Smart URI fetching/caching
Alias: perl-URI-Fetch

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240639


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-05-26 18:17 EST -------
I think you also need a build dependency on Test::More, although I guess the
tests are disabled by default so perhaps there's no point in that.  I've no idea
if you could have a conditional build dependency.

I ran the tests manually and they ran fine.

Review:
* source files match upstream:
   e395289713e509a323fd1d44cfc58785a45e661a64ca3f9c7ff9a046105012a8  
   URI-Fetch-0.08.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (perhaps Test::More if the tests were enabled)
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(URI::Fetch) = 0.08
   perl(URI::Fetch::Response)
   perl-URI-Fetch = 0.08-1.fc7
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Class::ErrorHandler)
   perl(Compress::Zlib)
   perl(LWP::UserAgent)
   perl(URI)
   perl(URI::Fetch::Response)
   perl(base)
   perl(constant)
   perl(strict)
* %check is present, but tests are necessarily disabled. All tests pass when run 
   manually:
   All tests successful.
   Files=3, Tests=88,  8 wallclock secs ( 0.30 cusr +  0.06 csys =  0.36 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.