[Bug 241403] Review Request: qgis - A user friendly Open Source Geographic Information System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qgis - A user friendly Open Source Geographic Information System


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241403





------- Additional Comments From silfreed at silfreed.net  2007-05-26 22:46 EST -------
Thanks for the comments; I believe I've addressed your initial concerns and 
updated files are here:
Spec URL: http://www.silfreed.net/download/repo/packages/qgis/qgis.spec
SRPM URL: 
http://www.silfreed.net/download/repo/packages/qgis/qgis-0.8.0-4.src.rpm

> * Please write all BuildRequires in main section.

Moved.

> * %makeinstall is highly forbidden.

Updated to `make DESTDIR=%{builddir} install`

> * stripping binaries is strictly forbidden to create debuginfo
>   rpm

Removed and enabled build of debuginfo package.

> * For python/test_export.py, verify which is proper,
>   to make this script have executable permission, or
>   to remove shebang.

I'm working with upstream to resolve this:
http://lists.qgis.org/pipermail/qgis-developer/2007-May/thread.html
They currently say this test script should be executable.

> * Fix directory ownership. For example, %{_libdir}/%{name} is
>   not owned by any package.

I believe this should be fixed.  Let me know if I missed any directories.

> * Shipping static archive is highly forbidden unless you have
>   some reasonable reason.
> * Also shipping libtool archive is highly forbidden.

These are the .a and .la files, correct?  They have been removed.

> * %defattr(-, root, root, -) is recommended

Fixed.

> * Using disttag is recommended

Added to Release.


I also found some source files that were being pulled into the debuginfo 
package and were marked executable.  I'm not familiar with the debuginfo 
packages so I'm not sure if something's being built incorrectly for them, but 
I went ahead and made the source files non-executable and notified upstream 
(http://lists.qgis.org/pipermail/qgis-developer/2007-May/001930.html)


Also below is the rpmlint reports:

 rpmlint -vi RPMS/qgis-*0.8.0-4* SRPMS/qgis-0.8.0-4.src.rpm
I: qgis checking
I: qgis-debuginfo checking
I: qgis-devel checking
W: qgis-devel no-documentation
The package contains no documentation (README, doc, etc).
You have to include documentation files.

I: qgis-grass checking
W: qgis-grass no-documentation
The package contains no documentation (README, doc, etc).
You have to include documentation files.

I: qgis-theme-nkids checking
W: qgis-theme-nkids no-documentation
The package contains no documentation (README, doc, etc).
You have to include documentation files.

I: qgis checking
E: qgis hardcoded-library-path in /usr/lib/qt4/bin
A library path is hardcoded to one of the following paths: /lib,
/usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}.


I'm not sure how to deal with the "hardcoded-library-path".  It was a bit of a 
hack for me to get this package to work with the qt4 libraries for FC6;  I'm 
not sure if there's any documentation on how to improve this or not.

-Doug

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.