[Bug 231809] Review Request: xmlrpc-epi - An implementation of the xmlrpc protocol in C

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xmlrpc-epi - An implementation of the xmlrpc protocol in C
Alias: xmlrpc-epi

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231809





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-05-28 03:34 EST -------
Created an attachment (id=155533)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=155533&action=view)
PATCH: fix 64 bit warnings

MUST:
=====
* rpmlint output is:
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License ok
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel x86_64
* BR: ok
* No locales
* ldconfig properly run for shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package

* -devel as package needed
* no .desktop file required

Must Fix:
---------
* Main package group should be System Environment/Libraries, 
  Development/Libraries is only for -devel sub packages.
* There are a few 64 bit related warning, please apply the attached patch to
  fix this. Also in general you may want to take a stab at fixing some of the
  other compiler warnings, esp. the missing prototypes ones.
* Change license to BSD-ish (it isn't the real BSD license)

Should Fix:
-----------
* Change Source0 URL from:
  Source0: http://dl.sf.net/sourceforge/xmlrpc-epi/xmlrpc-epi-%{version}.tar.gz

  To the (new guidelines adviced one):
  http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
  Notice that the current one doesn't work for me (spectool -g)
* Move NEWS to main package %doc, remove now empty %doc from devel
* remove empty %doc from examples %files


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.