[Bug 199406] Review Request: vtkdata - Example data file for VTK

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vtkdata - Example data file for VTK


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199406





------- Additional Comments From ed at eh3.com  2007-05-28 22:23 EST -------
GOOD:
+ spec is simple, legible, follows naming guidelines, etc.
+ rpmlint reports only a few ignore-able warnings:
    W: vtkdata no-%prep-section
    W: vtkdata no-%build-section
    W: vtkdata no-documentation
+ builds in mock on FC6 x86_64
+ permissions and dir ownership looks good to me
+ license matches that of VTK -- good

NEEDSWORK:
+ the srpm in comment #8 seems to be a broken link so I could not
  verify that source matches upstream -- but I do not consider 
  that to be a blocker as I was able to build a working package 
  from the spec file (which was not a broken link)

In regards to comment #6, I don't think it matters whether the      
directory is versioned or not.  If Axel would like to version it
then I think that's OK -- I just don't see how it voilates any of 
the guidelines or does any real harm.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.