[Bug 349791] Review Request: PySolFC-cardsets - Various cardsets for PySolFC

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PySolFC-cardsets - Various cardsets for PySolFC


https://bugzilla.redhat.com/show_bug.cgi?id=349791


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-11-01 17:04 EST -------
OK, back from vacation and caught up with life.  Now, to this review:

Looks much better; the issues I had are fixed.  rpmlint says only:
  PySolFC-cardsets.noarch: W: no-documentation
which is OK.

* source files match upstream:
   ae3ff94b50453c15aba07fc6fac9294e6f746d02746a77fe9eefa99864a07e28  
   PySolFC-Cardsets-1.1.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (none).
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   PySolFC-cardsets = 1.1-3
  =
   PySolFC = 1.1
* Manual testing shows things to work fine.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* acceptable content.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.