[Bug 367341] Review Request: rubyripper - Open-source secure ripper for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rubyripper - Open-source secure ripper for Linux


https://bugzilla.redhat.com/show_bug.cgi?id=367341


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-11-06 06:14 EST -------
Some random comments for 0.4.2-1:

* rpmlint
  - Please check your srpm/binary rpms by rpmlint before submitting
    to Review request.
------------------------------------------------------------
E: description-line-too-long Rubyripper is a digital audio extraction algorithm
that uses cdparanoia in a sophisticated
E: description-line-too-long way to make sure that a CD rip is done successfully
and accurately. It is very similar to
W: non-standard-group Application/Multimedia
W: invalid-license GPL
------------------------------------------------------------
   You can see what these rpmlint complaint means by
   "rpmlint -I description-line-too-long", for example.

   - For license, please refer to 
     http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
     http://fedoraproject.org/wiki/Licensing

* Ruby packaging issue:
  For general ruby packaging issues, please refer to:
  http://fedoraproject.org/wiki/Packaging/Ruby .

  - Ruby lib dependy
    - This package should have "Requires: ruby(abi) = 1.8'.

  - Ruby module dependency
    - For ruby module dependency, please specify them by module names,
      not by rpm names like perl. For example: "Requires: ruby(gtk2)"

  - Ruby dependency
    Note: ruby-gtk2 itself requires ruby-libs, but does not require ruby.

* koji build
  - koji build failed. At least desktop-file-utils is missing for BR.
    http://koji.fedoraproject.org/koji/taskinfo?taskID=227431

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.