[Bug 368161] Review Request: awn-extras-applets - extras applets of avant window navigator

bugzilla at redhat.com bugzilla at redhat.com
Wed Nov 7 04:15:53 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: awn-extras-applets - extras applets of avant window navigator


https://bugzilla.redhat.com/show_bug.cgi?id=368161


s.adam at diffingo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




------- Additional Comments From s.adam at diffingo.com  2007-11-06 23:15 EST -------
+ source files match upstream: d19dd1693a1a99613393006f846246c8328f68c9
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
- license field matches the actual license.
** License is GPLv2 or any later version - Please change the license tag to GPLv2+
+ license is open source-compatible, license text included in package.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
- package builds in mock
** avant-window-navigator-python is not included in the Fedora repositories nor
is it under review.
- package installs properly
Apart from note above, it works very well
+ debuginfo package looks complete.
+ rpmlint is silent.
+ final provides and requires are sane
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ code, not content.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list