[Bug 333491] Review Request: preload-0.4 - Preload is an adaptive readahead daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: preload-0.4 - Preload is an adaptive readahead daemon


https://bugzilla.redhat.com/show_bug.cgi?id=333491





------- Additional Comments From marc at mwiriadi.id.au  2007-11-08 06:37 EST -------

> Issues:
> 
> 1. For your Source0: line use the http://downloads.sourceforge.net/... url
> as mentioned in: http://fedoraproject.org/wiki/Packaging/SourceURL

Fixed this in the latest.
 
> 2. Can you add %{?_smp_mflags} to your make line?
> If that causes build problems please add a comment that it's disabled for
> that reason.
> 
Doesn't work added that to the changelog

> 3. Why the "%verify(not md5 size mtime)" on your config files?
> Also, why %ghost on the state and log file?

The original person that made the spec had that in there so I left it.  I have
adjusted it to noreplace only.  The ghost is to add the files and remove them on
uninstall is that not correct?

> 
> 4. You need some Requires because you have an init script.
> Take a look at:
>
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-a6d7a1ed9d77dbb8d4af067378a79b838aebb20a

Added in the latest version.

> 
> 5. rpmlint says:
> 
> preload.x86_64: E: non-standard-dir-perm /usr/share/doc/preload-0.4 0644
> 
> That dir should be 755...
> This is likely due to your "%defattr(-,root,root,0644)".
> That should be "%defattr(-,root,root,-)"

Fixed in the latest version.

> 
> preload.x86_64: W: service-default-enabled /etc/rc.d/init.d/preload
> preload.x86_64: W: service-default-enabled /etc/rc.d/init.d/preload
> 
> It's discouraged to default enable a service.
> Do you think this one should be default enabled?
> 

This is interesting I tested the latest version and rpmlint still generates the
error however after installing the actual rpm it wasn't enabled?  I would love
feedback on how to fix this so rpmlint doesn't generate the error.

> 6. Since you have a logrotate file, should "Requires: logrotate" ?

Fixed in the latest version.

> 
> 7. Not a blocker, but something to note: Upstream hasn't released a new
> version since 2006. Is upstream dead? Are you willing to provide security
> fixes, etc?

I've emailed him based on the email from here and on sf.net so I'll wait for a
reply.  I would say that I wouldn't be able to provide security fixes since I
don't know C if it was Java that would be fine but not C.

Updated files http://mwiriadi.id.au/fedora-spec/preload/

I have other packages however I wanted to submit one at a time to fedora since
dealing with multiple issues at the same time will confuse me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.