[Bug 322061] Review Request: asunder - A graphical Audio CD ripper and encoder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asunder - A graphical Audio CD ripper and encoder


https://bugzilla.redhat.com/show_bug.cgi?id=322061





------- Additional Comments From bugs.michael at gmx.net  2007-11-08 15:52 EST -------
> rpmlint -i asunder-0.9-1.src.rpm 
> asunder.src: W: non-coherent-filename asunder-0.9-1.src.rpm
> The file which contains the package should be named
> <NAME>-<VERSION>-<RELEASE>.<ARCH>.rpm.

Unimportant, but: rpm -qp --qf %{r}\\n asunder-0.9-1.src.rpm 
1.fc5


> %configure --prefix=%{_prefix}

That arg is the default.


> Requires:       libcddb >= 0.9.5
> BuildRequires:  libcddb-devel >= 0.9.5

Questionable.

Why? First of all, libcddb < 0.9.6 is more than three years old.
There have been several [much] newer versions since then. Secondly,
when building against 1.3.0 in Fedora 7, for instance, it is unsafe
to assume that >= 0.9.5 would be sufficient. That old version is
not ABI compatible.

Suggestion: Keep the version in the BuildRequires if you insist on
doing that (although Fedora's libcddb is latest). Drop the version
in the Requires and rely on rpmbuild's SONAME dependencies.


> #is already installed by desktop-file-install
> rm %{buildroot}%{_datadir}/applications/asunder.desktop

You can tell desktop-file-install to  --delete-original  and
give this file as input.

[...]

At run-time, I cannot get it to rip anything, not even as WAV.
It opens an error dialog:

  There was an error creating 15 files

or (when I select only one file):

  There was an error creating 1 files

$ asunder
Unable to delete WAV file "/home/qa/Desktop/Various Artists - Back In Time
II/Various Artists - Martin Galway/Galway Is God 2000 (CD mix by Jogeir
Liljedahl).wav": No such file or directory

It has only created an empty directory. The most I can get out of
it is an .m3u file if I enable that option.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.