[Bug 372161] Review Request: gnome-themes-extras - extra themes for gnome

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-themes-extras - extra themes for gnome


https://bugzilla.redhat.com/show_bug.cgi?id=372161





------- Additional Comments From alexl at users.sourceforge.net  2007-11-12 05:02 EST -------
Full review follows: the first section are all MUST fix items:

       - MUST: rpmlint output:
gnome-themes-extras.noarch: W: invalid-license LGPL
gnome-themes-extras.noarch: W: obsolete-not-provided gnome-themes-extras-0.9.0
      - MUST: remove Obsoletes: gnome-themes-themes, don't need to obsolete
packages that have the same name, yum does that by default
      - MUST: don't use %makeinstall, see:
http://fedoraproject.org/wiki/Packaging/Guidelines?highlight=%28%25makeinstall%29
use make install DESTDIR=%{buildroot} instead
      - MUST: License information in the tarball is not clear because README,
COPYING are empty and those that mention specific licenses, e.g Gion and Neu are
GPL not LGPL, please clarify with upstream and read
http://fedoraproject.org/wiki/Licensing if the package contains themes with
different licenses they must each be listed in the license tag, e.g. "License:
GPLv2+ and LGPLv2+" (see also
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines)
      - MUST: As above, License field is currently NOT valid, LGPL is not valid
see: http://fedoraproject.org/wiki/Licensing
      - MUST: COPYING is empty: file bug with upstream asking to include it in
package
      - MUST: BuildRequires: should increase gtk2-engines >= 2.11.7

The following is a checklist of all the OK items:

      - MUST: Meets Package Naming Guidelines.: OK
      - MUST: The spec file name: OK
      - MUST: Meets the Packaging Guidelines: OK
      - MUST: Spec file in American English: OK
      - MUST: The spec file legible: OK
      - MUST: MD5sum matches:
36698ee94c2281d5beab9b0a681f3350  gnome-themes-extras-2.20.tar.gz
http://ftp.gnome.org/pub/GNOME/sources/gnome-themes-extras/2.20/gnome-themes-extras-2.20.md5sum
36698ee94c2281d5beab9b0a681f3350  gnome-themes-extras-2.20.tar.gz
      - MUST: Builds in binary RPM on F-8 i386: OK
      - MUST: uses %find_lang, although not yet needed: OK
      - MUST: ldconfig: not required (noarch): OK
      - MUST: not relocatable: OK
      - MUST: Own all directories that it creates: OK
      - MUST:No duplicate files: OK
      - MUST: %defattr(...): OK
      - MUST: Each package must have a %clean section: OK
      - MUST: Consistently use macros: OK
      - MUST: Contains mainly permissable content, themes: OK
      - MUST: No large doc: OK
      - MUST: %doc not critical for run-time: OK
      - MUST: no devel package: OK
      - MUST: no static libraries: OK
      - MUST: No pkgconfig(.pc) files: OK
      - MUST: no library files with suffix: OK
      - MUST: no .la libtool archives: OK
      - MUST: not a GUI app: OK
      - MUST: Does not own files or directories already owned by other packages: OK
      - MUST: Runs rm -rf %{buildroot}: OK
      - MUST: Filenames valid UTF-8: OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.