[Bug 376321] Review Request: perl-Net-Packet-Target - An object for all network related stuff

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet-Target - An object for all network related stuff


https://bugzilla.redhat.com/show_bug.cgi?id=376321


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-11-12 05:23 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
7165c14c0cd02ec082c27b05a9ba5874  Net-Packet-Target-1.01.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
t/01-pod-coverage....ok
t/01-test-pod........ok
t/01-use.............ok
All tests successful.
Files=3, Tests=3,  0 wallclock secs ( 0.30 cusr +  0.05 csys =  0.35 CPU)
+ Package perl-Net-Packet-Target-1.01-1.fc8 ->
  Provides: perl(Net::Packet::Target) = 1.01
  Requires: perl(:MODULE_COMPAT_5.8.8) perl(Class::Gomor::Array) perl(strict)
perl(warnings)

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.