[Bug 366121] Review Request: httrack - Website copier and offline browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: httrack - Website copier and offline browser


https://bugzilla.redhat.com/show_bug.cgi?id=366121





------- Additional Comments From debarshi.ray at gmail.com  2007-11-12 12:29 EST -------
(In reply to comment #3)
> * About dangling-relative-symlink:

Fixed. I have contacted upstream for confirmation. Looking at the Makefiles, I
gather that the libraries under /usr/lib/httrack were created from the libtest/
files, which are appear to mere examples.

> * openssl header used?
>
> [...]
>
>     All in comments!!

Silly me!

However we do need a 'Requires: openssl' for the main package because
src/htsmodules.c tries to dlopen libssl.so*.
 
> By the way..
> * undefined-non-weak-symbol
 
Not yet fixed. I am looking into this.

> * generic header file name and generic macro name in
>   header file.

Not yet fixed.

Many of the macros are used to differentiate between #ifdef _WIN32 and so on.
Clearly we would not have _WIN32 defined in Fedora -- Fedora is GNU/Linux and
not Windows. So can I just remove all those _WIN32 (and similar) specific
portions from htsglobal.h ?

> * Dependency for firefox or so

Fixed.

> * File entry
>   - By the way, the file entries
>
> [...]
>
>     can be replaced by

I have used this style in all my specs, since I like to differentiate between
directories and files. Maybe this sounds silly, but I hope you will allow it. :-)

Spec: http://rishi.fedorapeople.org/httrack.spec
SRPM: http://rishi.fedorapeople.org/httrack-3.41.3-2.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.