[Bug 225702] Merge Review: docbook-slides

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: docbook-slides


https://bugzilla.redhat.com/show_bug.cgi?id=225702


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-11-15 01:06 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM But NOT for RPM.
docbook-slides.noarch: W: dangerous-command-in-%post chmod
docbook-slides.noarch: W: dangerous-command-in-%postun rm
=> these messages can be ignored for this package.
+ source files match upstream.
0fd5d334918d770946017dbc13d68471  docbook-slides-3.4.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ package docbook-slides-3.4.0-3.fc9 ->
  Provides: config(docbook-slides) = 3.4.0-3.fc9
  Requires: config(docbook-slides) = 3.4.0-3.fc9 docbook-dtds docbook-simple
docbook-xsl sgml-common
+ Not a GUI app.
APPROVED.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.