[Bug 226532] Merge Review: vorbis-tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: vorbis-tools


https://bugzilla.redhat.com/show_bug.cgi?id=226532





------- Additional Comments From michel.sylvan at gmail.com  2007-11-15 13:18 EST -------
Here's the full review; didn't find anything else to fix.

MUST
failed:
• license field accurate

passed:
• rpmlint: OK
• package name: OK
• spec file name: OK
• package guideline-compliant: OK
• license complies with guidelines: OK
• license file not deleted: OK
• spec in US English: OK
• spec legible: OK
• source matches upstream: OK
• builds under >= 1 archs, others excluded: OK
• build dependencies complete: OK
• locales handled using %find_lang, no %{_datadir}/locale: OK
• library -> ldconfig: NA
• relocatable: give reason: NA
• own all directories: OK
• no dupes in %files: OK
• permission: OK
• %clean RPM_BUILD_ROOT: OK
• macros used consistently: OK
• Package contains code: OK
• large docs => -doc: NA
• doc not runtime dependent: NA
• headers in -devel: NA
• static in -static: NA
• if contains *.pc, req pkgconfig: NA
• if libfiles are suffixed, the non-suffixed goes to devel: NA
• devel requires versioned base package: NA
• desktop file uses desktop-file-install: NA
• clean buildroot before install: OK
• filenames UTF-8: OK

SHOULD
failed:
• other subpackages should require versioned base
  Obsoletes/Provides should be versioned as well
• summary ending with period


passed:
• if license text missing, ask upstream to include it: NA
• desc and summary contain translations if available
• package build in mock on all architectures: OK
• package functioned as described: OK
• scriplets are sane: OK
• if main pkg is development-wise, pkgconfig can go in main package: NA
• require package not files: OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.