[Bug 382761] Review Request: python-cerealizer - Secure pickle-like module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-cerealizer - Secure pickle-like module


https://bugzilla.redhat.com/show_bug.cgi?id=382761


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-11-16 14:36 EST -------
Builds fine, rpmlint is clean.  Not really much here, honestly.  The only
comment I can make is that there's a test suite, but I can't get it to run in
the context of the build.  I'm sure a python wizard could make it work, but I'm
not one.  Hmm, wait:
  %check
  export PYTHONPATH=$RPM_BUILD_ROOT/%{python_sitelib}
  python test/regtest.py
works great:
  Ran 46 tests in 0.009s
  OK

So I guess you could do that, but no big deal.

* source files match upstream:
   8b654f89d79ee94badef696d88f5a15d859f7c54234d28542bb944b3854aaa29  
   Cerealizer-0.6.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   python-cerealizer = 0.6-1.fc9
  =
   python(abi) = 2.5

? %check is not present, but it could be added.  It runs fine.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.