[Bug 226415] Merge Review: sgml-common

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: sgml-common


https://bugzilla.redhat.com/show_bug.cgi?id=226415





------- Additional Comments From pertusus at free.fr  2007-11-17 09:49 EST -------
(In reply to comment #4)

> So the points which I want to discuss are:
> 1) Do you really think that including openjade tarball into sources to digout a
> few files from it is necessary? Those files didn't changed for years and I'm
> maintainer of Openjade package - and it is mentioned that the files are from
> OpenJade/pubtext dir.

Ok, but then add to the comment that you are the openjade maintainer
and verify that the timestamps are right such that it is easy to 
check the file age and compare with the files from openjade. If the 
timestamps are not right and cannot be changes (it is often the case
when the files are already in cvs), please note the original timestamps
in the spec file.

> 2) About that usage of automake package: This would require to rewrite some
> things inside the tarball and without adding any value - except more clean
package.

I don't really understand why. What it the technical issue here?
In any case having clean package is an explicit goal of 
fedora packaging and package review.

> 3) suggestion about with-docdir.patch for upstream - there is no upstream
> page/bugzilla afaik, last package version is made 3 years ago - so I don't know
> how can I get it to upstream and remove from fedora.

You can keep it in the srpm if you like but you shouldn't apply
it nor rerun the autotools, there are less intrusive ways to
achieve the same result. I can do some spec file patch if you like.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.