[Bug 383621] Review Request: gnofract4d - Gnofract 4D is a Gnome-based program to draw fractals

bugzilla at redhat.com bugzilla at redhat.com
Sat Nov 17 17:58:15 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnofract4d - Gnofract 4D is a Gnome-based program to draw fractals


https://bugzilla.redhat.com/show_bug.cgi?id=383621





------- Additional Comments From s.adam at diffingo.com  2007-11-17 12:58 EST -------
I've looked at test.py, two tests fail every time.

One checks the .desktop file's "Version=" key and compares it to the program
version, but this is invalid as Version= is used to designate the freedesktop
standard version, not the program version so that test has been patched out.

The second one tests generating an AVI file from fractals frames. Since
Transcode isn't in the Fedora repositories that test has also been patched out.
Selecting Director from the GUI informs the user that transcode isn't installed,
no harm done.

SPEC: http://www.diffingo.com/downloads/diffingo-repo/review/gnofract4d.spec
SRPM:
http://www.diffingo.com/downloads/diffingo-repo/review/gnofract4d-3.6-2.fc8.src.rpm

Changes:
* Sat Nov 17 2007 Stewart Adam <s.adam at diffingo.com> - 3.6-2
- License is actually LGPLv2+ because of lex.py, yacc.py, FCTGen.py
- Add patch for test suite files since two tests are invalid
- Update MIME and desktop databases
- Use virtual X for GUI test suite
- Remove redundant BR
- Remove redundant entries from %%files
- Fix rpmlint's errors about executable files/shebangs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list