[Bug 291741] Review Request: gnome-hearts - Game of Hearts implementation for gnome

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Game of Hearts implementation for gnome


https://bugzilla.redhat.com/show_bug.cgi?id=291741





------- Additional Comments From richip at richip.dhs.org  2007-11-17 19:12 EST -------
Remaining rpmlint errors and warnings:

rpmlint ../RPMS/x86_64/gnome-hearts-0.2-1.svn163.fc7.x86_64.rpm 
gnome-hearts.x86_64: E: non-executable-script
/usr/lib/python2.5/site-packages/gnome-hearts/players/pauline.py 0644
gnome-hearts.x86_64: E: non-executable-script
/usr/lib/python2.5/site-packages/gnome-hearts/players/luis.py 0644
gnome-hearts.x86_64: E: non-executable-script
/usr/lib/python2.5/site-packages/gnome-hearts/hearts.py 0644
gnome-hearts.x86_64: E: non-executable-script
/usr/lib/python2.5/site-packages/gnome-hearts/players/mike.py 0644
gnome-hearts.x86_64: E: non-executable-script
/usr/lib/python2.5/site-packages/gnome-hearts/definitions.py 0644
gnome-hearts.x86_64: E: non-executable-script
/usr/lib/python2.5/site-packages/gnome-hearts/player.py 0644
gnome-hearts.x86_64: E: non-executable-script
/usr/lib/python2.5/site-packages/gnome-hearts/players/john.py 0644
gnome-hearts.x86_64: E: non-executable-script
/usr/lib/python2.5/site-packages/gnome-hearts/stock_ai.py 0644
gnome-hearts.x86_64: W: unstripped-binary-or-object /usr/bin/gnome-hearts
gnome-hearts.x86_64: E: invalid-desktopfile
/usr/share/applications/gnome-hearts.desktop

I'm not sure why I'm getting a Warning for an unstripped-binary
(/usr/bin/gnome-hearts).

As for the invalid .desktop:

$ desktop-file-validate /usr/share/applications/gnome-hearts.desktop 
/usr/share/applications/gnome-hearts.desktop: error: file contains multiple
assignments of key "Name"

(Name=No Name) which I thought was fixed but the svn version I have seems to
still have it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.