[Bug 266941] Review Request: php-pear-Phing - A project build system based on Apache Ant

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Phing - A project build system based on Apache Ant


https://bugzilla.redhat.com/show_bug.cgi?id=266941


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-11-18 21:41 EST -------
* source files match upstream:
   7e745f5ddc1cd7cd84be10a0a85b089470468ea626d0d168f0c55c4387f95eb8  
   phing-2.3.0.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license (no LGPL version stated, so LGPLv2+ 
   applies)
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   php-pear(pear.phing.info/phing) = 2.3.0
   php-pear-phing = 2.3.0-1.fc9
  =
   /bin/sh
   /usr/bin/pear
   php-channel(pear.phing.info)
   php-cli >= 5.0.1
   php-pear
   php-pear(pear.phpunit.de/PHPUnit) >= 3.0
   php-pecl-xdebug >= 2.0.0

* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module registration)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.