[Bug 291371] Review Request: teg - teg is a clone of a clone of Risk

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: teg - teg is a clone of a clone of Risk


https://bugzilla.redhat.com/show_bug.cgi?id=291371





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-11-20 06:56 EST -------
Well, some comments for 0.11.2-6:

* Again sourceURL
  - For sourceforge tarball, please again refer to
    http://fedoraproject.org/wiki/Packaging/SourceURL

* Timestamp
  - Please try to add 'INSTALL="install -p"' option to
    'make install' to keep timestamps on installed files.
    Usually this method works for recent Makefiles.

* Duplicate file entry
  - Well, as I said in my comment 1, the %files entry
------------------------------------------------------
%files
%{_datadir}/pixmaps/teg_pix/
------------------------------------------------------
    contains the directory %{_datadir}/pixmaps/teg_pix itself
    and all files/directories/etc under the directory.
    So the additional %files entry
------------------------------------------------------
%{_datadir}/pixmaps/teg_pix/*
------------------------------------------------------
    is not needed, actually this causes the warnings in build.log
    like:
------------------------------------------------------
  1287  warning: File listed twice:
/usr/share/pixmaps/teg_pix/color_player_black.png
  1288  warning: File listed twice: /usr/share/pixmaps/teg_pix/color_player_blue.png
  1289  warning: File listed twice:
/usr/share/pixmaps/teg_pix/color_player_green.png
  1290  warning: File listed twice: /usr/share/pixmaps/teg_pix/color_player_pink.png
------------------------------------------------------

* GConf schemas file
  - We don't mark gconf schemas file as %config file (even if rpmlint
    warns about it).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.