[Bug 386531] Review Request: kuftp - Graphical FTP Client for KDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kuftp - Graphical FTP Client for KDE


https://bugzilla.redhat.com/show_bug.cgi?id=386531





------- Additional Comments From rdieter at math.unl.edu  2007-11-20 12:45 EST -------
2 suggestions:
1.  Group: Applications/Internet
2.  add --disable-static option to %configure
3.  use desktop-file-install
BuildRequires: desktop-file-utils

to %install, add
desktop-file-install \
 --dir=%{buildroot}%{_datadir}/applications/kde \ 
 --delete-original --vendor="" \
 --add-category=Network \
 %{buildroot}%{_datadir}/applnk/Internet/*.desktop
(add-category may or may not be needed depending if that .desktop Category is 
present already)
 
4.  Add icon scriptlets:

%post
touch --no-create %{_datadir}/icons/hicolor ||:
gtk-update-icon-cache -q %{_datadir}/icons/hicolor >& /dev/null ||:

%postun
touch --no-create %{_datadir}/icons/hicolor ||:
gtk-update-icon-cache -q %{_datadir}/icons/hicolor >& /dev/null ||:

5.  Can (probably) simplify BR's to just
BuildRequires: kdelibs3-devel zlib-devel

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.