[Bug 392291] Review Request: perl-Test-MinimumVersion - Check whether your code requires a newer perl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  perl-Test-MinimumVersion - Check whether your code requires a newer perl


https://bugzilla.redhat.com/show_bug.cgi?id=392291


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-11-21 00:43 EST -------
* source files match upstream:
   322c87ef495575005995001f8b69e44c2b252c4318cbc35b554d7dee671d067e  
   Test-MinimumVersion-0.007.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Test::MinimumVersion) = 0.007
   perl(Test::MinimumVersion::YAMLTiny) = 1.12
   perl-Test-MinimumVersion = 0.007-1.fc9
  =
   perl >= 0:5.005
   perl(:MODULE_COMPAT_5.8.8)
   perl(Exporter)
   perl(File::Find::Rule)
   perl(File::Find::Rule::Perl)
   perl(Perl::MinimumVersion)
   perl(Test::Builder)
   perl(strict)
   perl(vars)
   perl(version)

* %check is present and all tests pass:
   All tests successful.
   Files=2, Tests=2,  0 wallclock secs ( 0.19 cusr +  0.04 csys =  0.23 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.