[Bug 395651] Review Request: python-enum - Robust enumerated type support in Python

bugzilla at redhat.com bugzilla at redhat.com
Fri Nov 23 05:28:25 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-enum - Robust enumerated type support in Python


https://bugzilla.redhat.com/show_bug.cgi?id=395651





------- Additional Comments From tim.lauridsen at googlemail.com  2007-11-23 00:28 EST -------
MUST:
* package is named appropriately
* it is legal for Fedora to distribute this
? license field matches the actual license.
  Package is dual licensed GPLv2+ or Python, just use GPLv2+ in the License field.
* license is open source-compatible.
* specfile name matches %{name}
* summary and description fine
* correct buildroot
* %{?dist} is used
* license text included in package and marked with %doc
* package meets FHS (http://www.pathname.com/fhs/)
? changelog format fine 
See earlier comment.
* Packager tag not used
* Vendor tag not used
* Distribution tag not used
* License used and not Copyright 
* Summary tag does not end in a period
* specfile is legible
* package successfully compiles and builds on at least x86
* make sure lines are <= 80 characters
* specfile written in American English
* no -doc sub-package necessary
* no libraries
* no rpath
* not a GUI app
* no -devel sub-package necessary
* macros used appropriately and consistently
* no %makeinstall
* install section must begin with rm -rf $RPM_BUILD_ROOT or %{buildroot}
* no locale data
* split Requires(pre,post) into two separate lines
* package not relocatable
* package contains code
* package owns all directories and files
* no %files duplicates
* %defattrs present ( %defattr(-, root, root, -))
* %clean present
* %doc files do not affect runtime

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list