[Bug 398051] Review Request: accrete - Accrete is a physical simulation of solar system planet formation

bugzilla at redhat.com bugzilla at redhat.com
Sun Nov 25 03:04:55 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: accrete - Accrete is a physical simulation of solar system planet formation


https://bugzilla.redhat.com/show_bug.cgi?id=398051





------- Additional Comments From panemade at gmail.com  2007-11-24 22:04 EST -------
only mtrng.c is having BSD like license and other files have no license at all. 
So I guess there should not be any problem to have this package as Public Domain.

Also, I saw you can use Source URL as 
Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz

also, Compiler flags not honored. check
http://fedoraproject.org/wiki/Packaging/Guidelines#head-8b14098227aebff1cf6188939e9d0877295ac448

rpmlint on SRPM gave
accrete.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 1)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list