[Bug 398791] Review Request: BlockOutII - A free adaptation of the original BlockOut DOS game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: BlockOutII - A free adaptation of the original BlockOut DOS game
Alias: BlockOutII

https://bugzilla.redhat.com/show_bug.cgi?id=398791





------- Additional Comments From chris.stone at gmail.com  2007-11-26 12:31 EST -------
(In reply to comment #3)
> (In reply to comment #2)
> > * mv blockout %{name}-%{version}
> > 
> > Please remove the %{name}-%{version} from this line
> > 
> 
> ? You mean explicitly type the name and version instead of using macros? That
> will most likely get stale when the version changes.

Yes, there is no point at all in keeping the %{name}-%{version} in the comments
field, it does not get filled in by rpmbuild, and the only purpose of the
comments is to allow people to easily cut and paste from the comments to the
shell.  By using %{name}-%{version} you make it difficult to do this.

# mv blockout %{name}-%{version}
# cd BlockOutII-2.3

Please change the mv line to match the cd line, that is, replace the
%{name}-%{version} with BlockOutII-2.3

I don't expect you to keep bumping the versions in the comments, but someone
cutting and pasting will have an easier time of it.  Thanks.


> 
> > * <convert BlockOut/sounds/music.mp3 to ogg>
> > 
> > How do I perform this step??
> 
> I use mp32ogg (simple perl script, all deps are in fedora except for mpg321),
> but I'm leaving this open to the reader as there is no supported way todo this
> under Fedora.

Okay, I would suggest to go ahead and add a reference to mpg321 in the comments
for now, and try to get upstream to make the conversion there.

Thanks for fixing the build error, I'll try and complete the review sometime today.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.