[Bug 394651] Review Request: asio - cross-platform C++ library for network programming

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asio - cross-platform C++ library for network programming


https://bugzilla.redhat.com/show_bug.cgi?id=394651





------- Additional Comments From pertusus at free.fr  2007-11-28 18:05 EST -------
The timestamps are still not kept because INSTALL is not used,
instead install-sh is used, certainly because it creates directory.

The following should work:
make install DESTDIR=$RPM_BUILD_ROOT nobase_includeHEADERS_INSTALL='install -D
-p -m644'

rpmlint warnings to be fixed:
asio-devel.i386: W: spurious-executable-perm
/usr/share/doc/asio-devel-0.3.8/up_disabled.png
asio-devel.i386: W: spurious-executable-perm
/usr/share/doc/asio-devel-0.3.8/prev_disabled.png
asio-devel.i386: W: spurious-executable-perm
/usr/share/doc/asio-devel-0.3.8/next_disabled.png

And also many file-not-utf8 that are not a problem since files are
encoded in latin1 and it is what is in the headers.

I suggest putting the BuildRequires in the main package not 
the devel package.

I also suggest using dist since it will become arch at some point.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.