[Bug 331571] Review Request: xorg-x11-drv-radeonhd - driver for AMD GPG r5xx/r6xx Chipsets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-drv-radeonhd - driver for AMD GPG r5xx/r6xx Chipsets


https://bugzilla.redhat.com/show_bug.cgi?id=331571





------- Additional Comments From fedora at leemhuis.info  2007-10-15 10:30 EST -------
* driverdir defined, but not used (there are two places where it could be used); 

* why "%define date %(TZ=UTC date +%Y%m%d)"? That will produce a incorrect
alphatag tomorrow (e.g. according to release it will be 20071016, but the
sources are still those from 20071015)

* you shound include the xorg-x11-drv-radeonhd-snapshot.sh script

* why "Version: 1.1.1"?
[...]
(II) Module radeonhd: vendor="AMD GPG"
        compiled for 1.3.0, module version = 0.0.1
[...]

* is "BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)"
officially accepted these days? Looks to me like
http://fedoraproject.org/wiki/PackagingDrafts/BuildRoot is still a draft...

* I'd say trim the description and put"
 * regressions
 * bugs
 * errors
 * broken displays
" in one line; I'd also say that the link to the source code doesn't make much
sense in the description

* why the "-n xorg-x11-drv-radeonhd" for %files?

* don't use ".fc8" in changelog, as rpmlint will complain if one builds the
package on F7

* "ExcludeArch:   s390 s390x" not actually needed, but won't hurt

Looks fine otherwise.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.