[Bug 253909] Review Request: libpano13 - Library for manipulating panoramic images

bugzilla at redhat.com bugzilla at redhat.com
Mon Oct 1 04:06:00 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libpano13 - Library for manipulating panoramic images


https://bugzilla.redhat.com/show_bug.cgi?id=253909





------- Additional Comments From panemade at gmail.com  2007-10-01 00:05 EST -------
here comes my review
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
76b64d3e9bd9b9422bcb4dae4008555a  libpano13-2.9.12.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is small so no need of -doc subpackage.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc files are present.
+ -devel and -tools subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ ldconfig scriptlets are used.
+ package libpano13-2.9.12-4.fc8 ->
  Provides: libpano13.so.0
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4)
libc.so.6(GLIBC_2.4) libjpeg.so.62 libpano13.so.0 libpng12.so.0
libpng12.so.0(PNG12_0) libtiff.so.3 libz.so.1 rtld(GNU_HASH)
+ package libpano13-devel-2.9.12-4.fc8 ->
  Requires: libgcj-devel libjpeg-devel libpano13 = 2.9.12-3.fc8 libpano13.so.0
libpng-devel libtiff-devel zlib-devel
+ package libpano13-tools-2.9.12-4.fc8 ->
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libjpeg.so.62 libpano13 =
2.9.12-3.fc8 libpano13.so.0 libpng12.so.0 libtiff.so.3 libz.so.1 rtld(GNU_HASH)
+ Not a GUI app.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list