[Bug 292121] Review Request: boxes - Draw any kind of box around some given text

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boxes - Draw any kind of box around some given text


https://bugzilla.redhat.com/show_bug.cgi?id=292121





------- Additional Comments From thomas.moschny at gmx.de  2007-10-02 05:42 EST -------
(In reply to comment #2)
> http://hrozkovi.cz/boxes-1.1-2.fc7.src.rpm

Most issues are fixed. In line 45, you should replace '%{_prefix}/bin' 
with '%{_bindir}'.

Some minor remarks:
- There's a full stop missing after the %description.
- No need to put a '/' before %{_prefix} or similar paths.
- Default permissions for directories are not set in %defattr (fourth arg).
- The patch file contains a whitespace change.
- The patch file is named 'fix_smp_flags' but also comments the strip command 
from the Makefile.

> The only thing I could not reproduce was the error message " Alleged 
> system-wide config file '/usr/share/boxes' is a directory" .. could 
> you please retry? I've tested basic functionality of boxes on F7 i386
> and rawhide x86_64 and on both arches it runs fine...

Using your latest specfile, the package runs fine on F7 i386 and F7 x86_64.

(The problem lies in the Makefile: The sed command to patch src/boxes.h is 
only executed if there's something newer than src/boxes.h. So, changing 
GLOBALCONF via the make commandline only doesn't have any effect unless that 
sed command is forced to be executed, e.g. by touching or patching the 
Makefile, as you do now.)


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.