[Bug 226466] Merge Review: system-config-printer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: system-config-printer


https://bugzilla.redhat.com/show_bug.cgi?id=226466





------- Additional Comments From twaugh at redhat.com  2007-10-02 13:04 EST -------
system-config-printer.i386: W: conffile-without-noreplace-flag
/etc/security/console.apps/system-config-printer
===> Is this(noreplace) not needed?

I copied that from some other package that places a file in that directory. 
Changed.

system-config-printer.i386: W: dangerous-command-in-%post rm
==> Do you have any other workaround to avoid using rm?

The rm is necessary (it removes a cache file), and not dangerous.

system-config-printer-libs.i386: W: spurious-executable-perm
/usr/share/doc/system-config-printer-libs-0.7.74.3/pycups-1.9.27/examples/cupstree.py
===> any reason to have this as valid. I saw most of packages installing example
 files with 0644 mode.

Okay, changed.

system-config-printer-libs.i386: E: non-executable-script
/usr/share/system-config-printer/cupshelpers.py 0644
===> This MUST be solved. As you said its upstream. Can you provide a new SRPM
with upstream fix?

New upstream packaged.

system-config-printer-libs.i386: W: conffile-without-noreplace-flag
/etc/dbus-1/system.d/newprinternotification.conf
===> Is this(noreplace) not needed?

Copied from another package that places a file in that directory.  Changed,
we'll see if anyone complains.

http://twaugh.fedorapeople.org/system-config-printer/system-config-printer-0.7.74.4-1.fc8.src.rpm
http://twaugh.fedorapeople.org/system-config-printer/system-config-printer.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.