[Bug 280541] Review Request: setools - SELinux policy analysis tools

bugzilla at redhat.com bugzilla at redhat.com
Wed Oct 3 15:09:27 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: setools - SELinux policy analysis tools


https://bugzilla.redhat.com/show_bug.cgi?id=280541





------- Additional Comments From cpebenito at tresys.com  2007-10-03 11:09 EST -------
I looked at #314911, which ended up being tiny, and the only thing I saw was
that it didn't use %dist in the Release.  The package also doesn't match the
upstream package (tuncfg vs. tun).

Then I looked at #313361, which gets the errors:

RPM build errors:
    user jbowes does not exist - using root
    group jbowes does not exist - using root
    user jbowes does not exist - using root
    group jbowes does not exist - using root
    File not found by glob:
/var/tmp/python-zsi-2.0-1.fc8-root-root/usr/lib/python2.5/site-packages/*egg-info

so the files in the srpm need to have their ownership fixed, and the files
sections can be rewritten as:

%files
%defattr(-,root,root,-)
%doc CHANGES README
%{python_sitelib}/*
%exclude %{python_sitelib}/ZSI/twisted
%{_bindir}/*

%files twisted
%{python_sitelib}/ZSI/twisted

Then the permissions on scripts need to be fixed:
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/dispatch.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/schema.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/writer.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/wstools/c14n.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/TCnumbers.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/parse.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/auth.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/resolvers.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/wstools/__init__.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/TCtimes.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/ServiceContainer.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/client.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/TC.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/fault.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/TCapache.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/generate/wsdl2dispatch.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/__init__.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/digest_auth.py 0644
python-zsi.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/ZSI/TCcompound.py 0644

also the naming is different than the upstream (python-zsi vs. ZSI).


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list