[Bug 273301] Review Request: perl-Class-CSV - Class based CSV parser/writer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-CSV - Class based CSV parser/writer


https://bugzilla.redhat.com/show_bug.cgi?id=273301





------- Additional Comments From tibbs at math.uh.edu  2007-10-03 13:14 EST -------
Package builds fine, rpmlint is clean.

Actually, I'm a bit surprised that rpmlint doesn't complain about the duplicated
dependency for perl(Text::CSV_XS).  RPM finds one unversioned dependency itself,
while you specify a versioned one.  Frankly I'm not really sure how much of a
problem this is.  I know the same situation with Provides: is rather bad.

Honestly I'd just drop the versioned dependency  The oldest supported Fedora
release has always had the required version of Test::CSV_XS so there shouldn't
be any need for the versioned dependency.

Oddly, RPM doesn't automatically find any dependency on Class:Accessor, but it's
dependency detection is far from perfect.

Review:
* source files match upstream:
   bce148284947a2cf7375eac13260fbfe23cb6b8c215970e3af7049b36de5e354   
   Class-CSV-1.03.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
X final provides and requires include a duplicate dependency:
   per(Class::CSV)
   perl(Class::CSV::Base) = 1.3
   perl(Class::CSV::CSV_XS_Options)
   perl(Class::CSV::Line)
   perl-Class-CSV = 1.03-1.fc8
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Class::Accessor) >= 0.18
X  perl(Text::CSV_XS)
X  perl(Text::CSV_XS) >= 0.23
   perl(base)
   perl(constant)
   perl(strict)
   perl(vars)
   perl(warnings)

* %check is present and the single included test passes:
   All tests successful.
   Files=1, Tests=1,  0 wallclock secs ( 0.02 cusr +  0.01 csys =  0.03 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.