[Bug 277921] Review Request: jgoodies-forms - Java layout framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jgoodies-forms - Java layout framework


https://bugzilla.redhat.com/show_bug.cgi?id=277921


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-10-11 11:49 EST -------
! Well, actually I don't know how to use this package
  and I don't know well about Java, however anyway I will
  try to review this.

* CLASSPATH
  - I don't know what CLASSPATH does, however many other
    review requests seem to set CLASSPATH as ""
    (e.g. bug 251428). Would you try that?

* Timestamp
  - When using "install" or "cp" command, add "-p" option
    to keep timestamps.

* Misc rpmlint issues
----------------------------------------------------------------
jgoodies-forms.src: W: mixed-use-of-spaces-and-tabs (spaces: line 65, tab: line 59)
jgoodies-forms.src: W: strange-permission jgoodies-forms-build.patch 0600
jgoodies-forms.src: W: strange-permission forms-1_1_0.zip 0600
jgoodies-forms.noarch: W: file-not-utf8
/usr/share/doc/jgoodies-forms-1.1.0/docs/tutorial/introduction.html
jgoodies-forms.noarch: W: file-not-utf8
/usr/share/doc/jgoodies-forms-1.1.0/docs/reference/colsandrows.html
jgoodies-forms.noarch: W: file-not-utf8
/usr/share/doc/jgoodies-forms-1.1.0/docs/reference/cells.html
----------------------------------------------------------------
  SUMMARY:
  - Unify indentation. Please use spaces or tabs, not both
  - Change the permission of the files in srpm to 0644.
  - Change the encodings of HTML files to UTF-8.
    ! Note:
      When changing the encodings of HTML files into UTF-8, you also
      have to change the string of "charset".
      For example, 
      /usr/share/doc/jgoodies-forms-1.1.0/docs/tutorial/introduction.html
      contains the line:
----------------------------------------------------------------
        <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
----------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.