[Bug 327351] Review Requiest: python-alsa - Python binding for the ALSA library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Requiest: python-alsa - Python binding for the ALSA library


https://bugzilla.redhat.com/show_bug.cgi?id=327351


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-10-12 05:21 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
3f3153bf5f4d5627655dbbbd71537f1e  pyalsa-1.0.15rc2.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Package  python-alsa-1.0.15-0.3.rc2.fc8 ->
  Provides: alsacard.so alsacontrol.so alsahcontrol.so alsamixer.so
  Requires: libasound.so.2 libasound.so.2(ALSA_0.9) libasound.so.2(ALSA_0.9.3)
libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4)
libpthread.so.0 libpython2.5.so.1.0 python(abi) = 2.5 rtld(GNU_HASH)
+ Not a GUI app.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.